[ISSUE #2314]Add License header for NotifyMinBrokerIdChangeRequestHeader #2315
Conversation
WalkthroughThis pull request introduces a new file Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
🔊@flydream-ylgw 🚀Thanks for your contribution🎉！ 💡CodeRabbit(AI) will review your code first🔥！ Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
rocketmq-rust-bot
added
AI review first
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
rocketmq-remoting/src/protocol/header/namesrv/brokerid_change_request_header.rs (2)
Line range hint
102-104: Implement the required check_fields method.The
check_fields()method is currently marked withtodo!(), which will panic at runtime. This method should validate the header fields according to the protocol requirements.Would you like me to help implement the field validation logic for this method?
Line range hint
106-166: Fix duplicate insertion of ha_broker_addr in to_map method.The
ha_broker_addrfield is being inserted into the map twice, which is redundant and could mask bugs. The second insertion should be removed.Apply this fix:
if let Some(ref ha_broker_addr) = self.ha_broker_addr { map.insert( CheetahString::from_static_str( NotifyMinBrokerIdChangeRequestHeader::HA_BROKER_ADDR, ), ha_broker_addr.clone(), ); } if let Some(ref offline_broker_addr) = self.offline_broker_addr { map.insert( CheetahString::from_static_str( NotifyMinBrokerIdChangeRequestHeader::OFFLINE_BROKER_ADDR, ), offline_broker_addr.clone(), ); } - if let Some(ref ha_broker_addr) = self.ha_broker_addr { - map.insert( - CheetahString::from_static_str( - NotifyMinBrokerIdChangeRequestHeader::HA_BROKER_ADDR, - ), - ha_broker_addr.clone(), - ); - }Additionally, consider refactoring the repetitive map insertion code to reduce duplication:
impl NotifyMinBrokerIdChangeRequestHeader { fn insert_if_some<T: ToString>( map: &mut HashMap<CheetahString, CheetahString>, key: &'static str, value: &Option<T>, ) { if let Some(v) = value { map.insert( CheetahString::from_static_str(key), CheetahString::from_string(v.to_string()), ); } } }
🧹 Nitpick comments (1)
rocketmq-remoting/src/protocol/header/namesrv/brokerid_change_request_header.rs (1)
Line range hint
31-47: Add documentation for the struct and its fields.While the struct definition is well-structured, it would benefit from documentation comments explaining:
- The purpose of the struct
- The significance of each field
- Any constraints or valid value ranges for fields like
min_broker_idAdd documentation like this:
+/// Represents a request header for notifying changes in minimum broker ID. +/// This header is used in the RocketMQ namesrv protocol for broker management. #[derive(Debug, Clone, Serialize, Deserialize, Default)] pub struct NotifyMinBrokerIdChangeRequestHeader { + /// The minimum broker ID in the cluster #[serde(rename = "minBrokerId")] pub min_broker_id: Option<u64>,
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
rocketmq-remoting/src/protocol/header/namesrv/brokerid_change_request_header.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: build (windows-latest, nightly)
- GitHub Check: build (windows-latest, stable)
- GitHub Check: build (macos-latest, nightly)
- GitHub Check: build (macos-latest, stable)
- GitHub Check: build (ubuntu-latest, nightly)
- GitHub Check: build
- GitHub Check: build (ubuntu-latest, stable)
- GitHub Check: test
- GitHub Check: auto-approve
🔇 Additional comments (1)
rocketmq-remoting/src/protocol/header/namesrv/brokerid_change_request_header.rs (1)
1-16: LGTM! License header is properly added.The Apache 2.0 license header is correctly formatted and included as required by the PR objectives.
rocketmq-rust-bot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage 28.20% 28.20%
=======================================
Files 504 504
Lines 72470 72470
=======================================
Hits 20440 20440
Misses 52030 52030 ☔ View full report in Codecov by Sentry. |
Which Issue(s) This PR Fixes(Closes)
Fixes #2314
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
New Features
NotifyMinBrokerIdChangeRequestHeaderfor handling broker ID change notificationsChores