Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2317]🤡Remove broker crate dependeces of log crate🧑‍💻 #2318

Merged
merged 1 commit into from
Jan 18, 2025
Merged

[ISSUE #2317]🤡Remove broker crate dependeces of log crate🧑‍💻 #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion rocketmq-broker/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ thiserror = { workspace = true }
trait-variant = { workspace = true }
cheetah-string = { workspace = true }
dashmap = { workspace = true }
log = "0.4.25"
[dev-dependencies]
mockall = "0.13.1"
static_assertions = { version = "1" }
Expand Down
3 changes: 2 additions & 1 deletion rocketmq-broker/src/broker_bootstrap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
use log::info;

use rocketmq_common::common::broker::broker_config::BrokerConfig;
use rocketmq_common::common::server::config::ServerConfig;
use rocketmq_rust::wait_for_signal;
use rocketmq_store::config::message_store_config::MessageStoreConfig;
use tracing::error;
use tracing::info;

use crate::broker_runtime::BrokerRuntime;

Expand Down
9 changes: 3 additions & 6 deletions rocketmq-broker/src/failover/escape_bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,13 +501,10 @@
)
.await;
if result.is_none() {
log::warn!(
warn!(

Check warning on line 504 in rocketmq-broker/src/failover/escape_bridge.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/failover/escape_bridge.rs#L504 

Added line #L504 was not covered by tests
"getMessageResult is null, innerConsumerGroupName {}, topic {}, offset \
{}, queueId {}",
inner_consumer_group_name,
topic,
offset,
queue_id
inner_consumer_group_name, topic, offset, queue_id
);
return (None, "getMessageResult is null".to_string(), false);
}
Expand All @@ -517,7 +514,7 @@
if list.is_empty() {
let need_retry = status.unwrap() == GetMessageStatus::OffsetFoundNull;
// && message_store.is_tiered_message_store();
log::warn!(
warn!(

Check warning on line 517 in rocketmq-broker/src/failover/escape_bridge.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/failover/escape_bridge.rs#L517 

Added line #L517 was not covered by tests
"Can not get msg, topic {}, offset {}, queueId {}, needRetry {},",
topic,
offset,
Expand Down
Loading