[ISSUE #2398]🐛Fix GetMessageStatus judgement not incorret #2399
Conversation
WalkthroughThe pull request modifies the conditional logic in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
🔊@mxsm 🚀Thanks for your contribution🎉！ 💡CodeRabbit(AI) will review your code first🔥！ Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
rocketmq-rust-bot
added
AI review first
rocketmq-rust-bot
requested review from
rocketmq-rust-bot,
SpaceXCN and
TeslaRustor
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
rocketmq-broker/src/processor/pop_message_processor.rs (1)
1056-1060: Consider storing the unwrapped status in a local variable.The conditional checks call
result_inner.status().unwrap()multiple times. Sinceresult_inner.status().is_some()is already confirmed, you can store the unwrapped value in a local variable for cleaner and safer code:-} else if (result_inner.status().is_some() - && (result_inner.status().unwrap() == GetMessageStatus::NoMatchedMessage - || result_inner.status().unwrap() == GetMessageStatus::OffsetFoundNull - || result_inner.status().unwrap() == GetMessageStatus::MessageWasRemoving - || result_inner.status().unwrap() == GetMessageStatus::NoMatchedLogicQueue)) - && result_inner.next_begin_offset() > -1 -{ +} else if let Some(status) = result_inner.status() { + if (status == GetMessageStatus::NoMatchedMessage + || status == GetMessageStatus::OffsetFoundNull + || status == GetMessageStatus::MessageWasRemoving + || status == GetMessageStatus::NoMatchedLogicQueue) + && result_inner.next_begin_offset() > -1 + { // Existing logic... } }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
rocketmq-broker/src/processor/pop_message_processor.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: build (windows-latest, nightly)
- GitHub Check: build (windows-latest, stable)
- GitHub Check: build (macos-latest, nightly)
- GitHub Check: build (macos-latest, stable)
- GitHub Check: build (ubuntu-latest, nightly)
- GitHub Check: test
- GitHub Check: build (ubuntu-latest, stable)
- GitHub Check: build
- GitHub Check: auto-approve
🔇 Additional comments (1)
rocketmq-broker/src/processor/pop_message_processor.rs (1)
1056-1060:⚠️ Potential issueImplement or handle the unimplemented! branch.
Calling
unimplemented!()in the non-order scenario will immediately panic if triggered. Consider providing proper handling (e.g., committing offsets or returning a specific response code):} else { - unimplemented!("PopMessageProcessor pop_msg_from_queue") + // Example approach: commit offset & proceed gracefully + let offset = result_inner.next_begin_offset(); + self.broker_runtime_inner + .consumer_offset_manager() + .commit_offset( + channel.remote_address().to_string().into(), + &request_header.consumer_group, + topic, + queue_id, + offset, + ); + final_response.set_code_ref(ResponseCode::Success); + // Additional logic or response... }Likely invalid or redundant comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
=======================================
Coverage 28.62% 28.62%
=======================================
Files 507 507
Lines 73321 73321
=======================================
+ Hits 20986 20989 +3
+ Misses 52335 52332 -3 ☔ View full report in Codecov by Sentry. |
rocketmq-rust-bot
added
approved
Which Issue(s) This PR Fixes(Closes)
Fixes #2398
Brief Description
How Did You Test This Change?
Summary by CodeRabbit