[ISSUE apache#6138] Skip log empty remoting code distribution (apache…

…#6136) * skip log empty code distribution * skip log empty remoting code distirbution * skip log empty code distribusion
mxsm · Feb 23, 2023 · c63219e · c63219e
1 parent df1a6d5
commit c63219e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
@@ -395,10 +395,17 @@ private void prepareSharableHandlers() {
 
     private void printRemotingCodeDistribution() {
         if (distributionHandler != null) {
-            TRAFFIC_LOGGER.info("Port: {}, RequestCode Distribution: {}",
-                nettyServerConfig.getListenPort(), distributionHandler.getInBoundSnapshotString());
-            TRAFFIC_LOGGER.info("Port: {}, ResponseCode Distribution: {}",
-                nettyServerConfig.getListenPort(), distributionHandler.getOutBoundSnapshotString());
+            String inBoundSnapshotString = distributionHandler.getInBoundSnapshotString();
+            if (inBoundSnapshotString != null) {
+                TRAFFIC_LOGGER.info("Port: {}, RequestCode Distribution: {}", 
+                    nettyServerConfig.getListenPort(), inBoundSnapshotString);
+            }
+
+            String outBoundSnapshotString = distributionHandler.getOutBoundSnapshotString();
+            if (outBoundSnapshotString != null) {
+                TRAFFIC_LOGGER.info("Port: {}, ResponseCode Distribution: {}", 
+                    nettyServerConfig.getListenPort(), outBoundSnapshotString);
+            }
         }
     }
 

diff --git a/...ing/src/main/java/org/apache/rocketmq/remoting/netty/RemotingCodeDistributionHandler.java b/...ing/src/main/java/org/apache/rocketmq/remoting/netty/RemotingCodeDistributionHandler.java
@@ -75,8 +75,8 @@ private Map<Integer, Long> getDistributionSnapshot(Map<Integer, LongAdder> count
     }
 
     private String snapshotToString(Map<Integer, Long> distribution) {
-        StringBuilder sb = new StringBuilder("{");
         if (null != distribution && !distribution.isEmpty()) {
+            StringBuilder sb = new StringBuilder("{");
             boolean first = true;
             for (Map.Entry<Integer, Long> entry : distribution.entrySet()) {
                 if (0L == entry.getValue()) {
@@ -85,9 +85,13 @@ private String snapshotToString(Map<Integer, Long> distribution) {
                 sb.append(first ? "" : ", ").append(entry.getKey()).append(":").append(entry.getValue());
                 first = false;
             }
+            if (first) {
+                return null;
+            }
+            sb.append("}");
+            return sb.toString();
         }
-        sb.append("}");
-        return sb.toString();
+        return null;
     }
 
     public String getInBoundSnapshotString() {