Suggested edits for the tutorial and help. #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestions to the help text for Configuration Management |
mshulman
changed the title
godind
requested changes
Apr 5, 2024
|
Sorry about that!
…-ms
On Thu, Apr 4, 2024, 9:41 PM David G ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/app/widgets/widget-numeric/widget-numeric.component.ts
<#362 (comment)>:
> @@ -320,7 +320,7 @@ export class WidgetNumericComponent extends BaseWidgetComponent implements OnIni
let valueText: string = '';
const maxTextWidth = Math.floor(this.canvasMM.nativeElement.width * 0.45);
- const maxTextHeight = Math.floor(this.canvasMM.nativeElement.height * 0.075);
+ const maxTextHeight = Math.floor(this.canvasMM.nativeElement.height * 0.13);
I could have approved the other changes. Try to create PRs that are
targeted to one area or feature set. Next time ;)
—
Reply to this email directly, view it on GitHub
<#362 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALKNBDLIABHSEQJQU3N3UTY3YTQ7AVCNFSM6AAAAABFUIXAIGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBRHA2DGNRVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It looked good on my setup when I tested.
I really need to learn how Angular Canvases work.
…-ms
On Thu, Apr 4, 2024, 9:41 PM David G ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/app/widgets/widget-numeric/widget-numeric.component.ts
<#362 (comment)>:
> @@ -320,7 +320,7 @@ export class WidgetNumericComponent extends BaseWidgetComponent implements OnIni
let valueText: string = '';
const maxTextWidth = Math.floor(this.canvasMM.nativeElement.width * 0.45);
- const maxTextHeight = Math.floor(this.canvasMM.nativeElement.height * 0.075);
+ const maxTextHeight = Math.floor(this.canvasMM.nativeElement.height * 0.13);
I could have approved the other changes. Try to create PRs that are
targeted to one area or feature set. Next time ;)
—
Reply to this email directly, view it on GitHub
<#362 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALKNBDLIABHSEQJQU3N3UTY3YTQ7AVCNFSM6AAAAABFUIXAIGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBRHA2DGNRVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No worries. That's what PR reviews are for. But they do take time! |
|
Reverted the maxHeight change. |
mshulman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the max height to 0.075 of the canvas, set it to 0.13 of the canvas.
This looks a little bigger, and still resizes appropriately.