XNode#toString() cannot display all information

[zhanjinhao]

MyBatis version

3.5.5

java version

1.8

discription

I found that this method org.apache.ibatis.parsing.XNode#toString() has a defect, it only displays nodes of type Node.ELEMENT_NODE. The reason for this problem is that the method org.apache.ibatis.parsing.XNode#getChildren will only list the child nodes of type Node.ELEMENT_NODE. Therefore, when I am debugging, I cannot see all the information.

a xml file

<mapper namespace="demo.StudentMapper">
  <select id="selectFullStudent" resultMap="fullResult" databaseId="mysql">
    select
      STUDENT.ID ID,
      STUDENT.SNO SNO,
      STUDENT.SNAME SNAME,
      STUDENT.SSEX SSEX,
      STUDENT.SBIRTHDAY SBIRTHDAY,
      STUDENT.CLASS CLASS,
      SCORE.CNO CNO,
      SCORE.DEGREE DEGREE,
      HOUSE.HOUSE_ID HOUSE_ID,
      HOUSE.HOUSE_HOLDER HOUSE_HOLDER,
      HOUSE.HOUSE_MEMBER HOUSE_MEMBER
    from STUDENT, SCORE, HOUSE
    <where>
      <if test="sex != null">
        STUDENT.SSEX = #{sex};
      </if>
      and STUDENT.SNO = SCORE.SNO and HOUSE.HOUSE_MEMBER = STUDENT.SNO
    </where>
  </select>
</mapper>

Java code

package issue;

import org.apache.ibatis.parsing.XNode;
import org.apache.ibatis.parsing.XPathParser;

import java.io.InputStream;

public class ReproduceXnode {
    public static void main(String[] args) {
        InputStream resourceAsStream = ReproduceXnode.class.getClassLoader().getResourceAsStream("issue/StudentMapper.xml");
        XPathParser xPathParser = new XPathParser(resourceAsStream);
        XNode select = xPathParser.evalNode("mapper/select");
        System.out.println(select.toString());
    }
}

Expected result

  <select id="selectFullStudent" resultMap="fullResult" databaseId="mysql">
    select
      STUDENT.ID ID,
      STUDENT.SNO SNO,
      STUDENT.SNAME SNAME,
      STUDENT.SSEX SSEX,
      STUDENT.SBIRTHDAY SBIRTHDAY,
      STUDENT.CLASS CLASS,
      SCORE.CNO CNO,
      SCORE.DEGREE DEGREE,
      HOUSE.HOUSE_ID HOUSE_ID,
      HOUSE.HOUSE_HOLDER HOUSE_HOLDER,
      HOUSE.HOUSE_MEMBER HOUSE_MEMBER
    from STUDENT, SCORE, HOUSE
    <where>
      <if test="sex != null">
        STUDENT.SSEX = #{sex};
      </if>
      and STUDENT.SNO = SCORE.SNO and HOUSE.HOUSE_MEMBER = STUDENT.SNO
    </where>
  </select>

Actual result

<select resultMap="fullResult" databaseId="mysql" id="selectFullStudent">
    <where>
        <if test="sex != null">
        STUDENT.SSEX = #{sex};
      </if>
    </where>
</select>

[nothingzhl]

I'm fixed this issue.Pr