Argument name based constructor auto-mapping #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple constructors, users must use `@AutomapConstructor`. Although it would be possible to implement find-the-best-match type logic,
# Conflicts: # src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java # src/main/java/org/apache/ibatis/session/Configuration.java # src/test/java/org/apache/ibatis/builder/XmlConfigBuilderTest.java # src/test/java/org/apache/ibatis/builder/xsd/XmlConfigBuilderTest.java
# Conflicts: # src/main/java/org/apache/ibatis/session/Configuration.java # src/site/es/xdoc/configuration.xml # src/site/ja/xdoc/configuration.xml # src/site/ko/xdoc/configuration.xml # src/site/xdoc/configuration.xml # src/site/zh/xdoc/configuration.xml
harawata
force-pushed
the
arg-name-based-constructor-automapping
branch
from
a9451fc to
7a76f77
Compare
…perty-automapping This logic is applied only to the new arg-name-based constructor auto-mapping. Although it is possible (and it may also be the expected behavior) to apply the same logic to the old column-order-based constructor auto-mapping, it will break many existing solutions, probably.
|
@kazuki43zoo @jeffgbutler @hazendaz I plan to merge this soon. |
hazendaz
reviewed
Apr 21, 2022
| @@ -519,6 +525,10 @@ private List<UnMappedColumnAutoMapping> createAutomaticMappings(ResultSetWrapper | |||
| if (autoMapping == null) { | |||
| autoMapping = new ArrayList<>(); | |||
| final List<String> unmappedColumnNames = rsw.getUnmappedColumnNames(resultMap, columnPrefix); | |||
| List<String> mappedInConstructorAutoMapping = constructorAutoMappingColumns.remove(mapKey); | |||
There was a problem hiding this comment.
@harawata Might be useful for a comment here to understand why its removing vs others getting data. I think I grasp it but find it somewhat confusing.
There was a problem hiding this comment.
Thank you, @hazendaz !
Added a brief comment.
The entry is used only once, so there is no point in keeping it on memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at fixing #2192
argNameBasedConstructorAutoMappingis added.Compared to the current (=column order based) constructor auto-mapping, name-based auto-mapping is more lenient.
Cc: @h3adache