Add Unit Test for PooledDataSource #2809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote several unit tests for PooledDataSource.
1. shouldBlockUntilConnectionIsAvailableInPooledDataSource
If program tries to get a connection beyond the number of dataSource.getPoolMaximumActiveConnections, it should be blocked.
2. PoppedConnectionShouldBeNotEqualToClosedConnection
The Popped Connection should be not equal to previously closed connection. When closing a connection, it should generate new connection and stash away it to idleConnections in PoolState.
3. shouldEnsureCorrectIdleConnectionCount
When closing a connection, the number of idle connection in idleConnections in PoolState increases by one, but not beyond dataSource.setPoolMaximumIdleConnections
4. connectionShouldBeAvailableAfterMaximumCheckoutTime
It is the test extending test 1. If program tries to get a connection beyond the number of dataSource.getPoolMaximumActiveConnections, program is blocked. But If time passes beyond dataSource.getPoolMaximumCheckoutTime, a connection should be available.
5. forceCloseAllShouldRemoveAllActiveAndIdleConnection
forceCloseAll should remove all active and idle connections.
Thank you.