Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] CI on JDK 22 #2939

Merged
merged 4 commits into from
Aug 26, 2023
Merged

[actions] CI on JDK 22 #2939

merged 4 commits into from
Aug 26, 2023

Conversation

harawata
Copy link
Member

  • 21 reaches RC
  • 22 EA is available

@coveralls
Copy link

coveralls commented Aug 22, 2023

Coverage Status

coverage: 87.632% (+0.08%) from 87.548% when pulling 11284e2 on harawata:ci-on-jdk21 into f377db0 on mybatis:master.

pom.xml Outdated
@@ -153,6 +153,8 @@

<!-- Reproducible Builds -->
<project.build.outputTimestamp>1678513628</project.build.outputTimestamp>

<allowed.build.jdks>[11,12),[17,18),[20,21),[21,23)</allowed.build.jdks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harawata Did you mean 22,23 in the last spot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hazendaz ,

I was going to ask you, actually.
I copied the following line from the parent which has [20,21),[21,22) and modified it so that the build can run on 22.
https://github.com/mybatis/parent/blob/master/pom.xml#L267

Are you suggesting to use [11,12),[17,18),[20,21),[22,23) ?
That would exclude 21 which is LTS version, so it does not seem right.
https://www.oracle.com/java/technologies/java-se-support-roadmap.html

@hazendaz
Copy link
Member

hazendaz commented Aug 25, 2023 via email

@harawata
Copy link
Member Author

@hazendaz ,

Got it!
I have updated the line and will merge this later.
Thank you for the review!

@hazendaz hazendaz self-assigned this Aug 26, 2023
@hazendaz hazendaz merged commit 849926e into mybatis:master Aug 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants