fix: Fix flaky test (testBlockingCache) on master/pr's #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use more modern approach to shut down thread pool, `awaitTermination` (prevent infinite loop in case of failure) - Use assertJ so we can get the reason it failed if it does - Change to `greaterThanOrEqualTo` as this test is successful if the calls blocked on each other and we know that with (500ms * 2)
|
Thank you, @epochcoder ! I was aware of the flakiness, but didn't pay much attention to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing sporadically on some CI runners.
awaitTermination(prevent infinite loop in case of failure)greaterThanOrEqualToas this test is successful if the calls blocked on each other and we know that with (500ms * 2)