Fix code scanning alert no. 6: Resolving XML external entity in user-controlled data #3251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mybatis/mybatis-3/security/code-scanning/6
To fix the problem, we need to disable the parsing of DTDs and external entities in the
DocumentBuilderFactory
. This can be done by setting specific features on theDocumentBuilderFactory
instance. The changes should be made in thecreateDocument
method of theXPathParser
class.http://apache.org/xml/features/disallow-doctype-decl
totrue
.http://xml.org/sax/features/external-general-entities
tofalse
.http://xml.org/sax/features/external-parameter-entities
tofalse
.Suggested fixes powered by Copilot Autofix. Review carefully before merging.