Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use getters and setters without get- or set- prefix to serialize/deserialize DB data, 2nd attempt #730

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexvas
Copy link

@alexvas alexvas commented Jul 4, 2016

First attempt with comments is here.

This branch contains:

  • two small fixes:
  1. static method could not be getter or setter
  2. fixed a corner case of write-only property reflection with setter inherited using generics
  • a small change: Reflector is final, so it is not possible to define custom reflection in the client code
  • a feature that anything getting and setting goes (single-Reflector implementation)

I see three implied regressions here:

  1. static getters or setters will stop working
  2. custom Reflectors stop working
  3. when a few setters with single argument of different types found for a write-only property, MyBatis will silently skip the property instead of bailing out.

The latter worries me the most. Should Reflector write some log information in this case?

Alexander Vasiljev added 5 commits July 4, 2016 16:44
no change in functionality yet, see next commits
Though the class was exposed in public API as a return value of ReflectorFactory.findForClass(...),
 it is not intended to be public. This class is used in the most frequently changed part of MyBatis,
 so it should not be inheritable in application code.
@alexvas
Copy link
Author

alexvas commented Jul 10, 2016

Closing and reopening request to restart CI check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant