Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include webcomponents polyfill #483

Merged
merged 3 commits into from
Nov 18, 2018

Conversation

elgarfo
Copy link
Contributor

@elgarfo elgarfo commented Nov 17, 2018

firefox does not include support for html imports (see: https://developer.mozilla.org/en-US/docs/Web/Web_Components/HTML_Imports)
adding webcomponents 1.x polyfill fixes this issue, which in turn fixes #338

tested on:

  • windows 10 x64 1803b17134.345
  • firefox 63.0 x64
  • mycontroller 1.3.0 stable release

firefox does not include support for html imports (see: https://developer.mozilla.org/en-US/docs/Web/Web_Components/HTML_Imports)
adding webcomponents 1.x polyfill fixes this issue, which in turn fixes mycontroller-org#338
@jkandasa
Copy link
Member

@elgarfo Thank you for the PR! Your contribution to MyController is very valuable.
MyController is designed to work without internet connectivity. You have given internet link.
Could you please add this library under https://github.com/mycontroller-org/mycontroller/tree/development/dist/src/main/package/www/libs and provide the local reference?

Thank you!

@elgarfo
Copy link
Contributor Author

elgarfo commented Nov 17, 2018

@jkandasa the files are now local and i changed the reference in index.html.
do you know what i need to do, to make the build successful? i can't seem to find the reason why the build is failing.

@jkandasa
Copy link
Member

@elgarfo Thank you for the update.
Looks like you have extra space on the following line(reported by travis CI), could you please remove it?

/home/travis/build/mycontroller-org/mycontroller/dist/src/main/package/www/index.html:74: Line has trailing spaces.

@jkandasa jkandasa merged commit fb3d0d9 into mycontroller-org:development Nov 18, 2018
@jkandasa
Copy link
Member

@elgarfo Thank you so much for your contribution!

@elgarfo elgarfo deleted the patch-1 branch November 25, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gauge.min.js custom widget not working with firefox browser
2 participants