-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace webcomponents import #486
Replace webcomponents import #486
Conversation
… load additional scripts faster
… from being created
@elgarfo Thank you for the awesome work! |
@elgarfo All works great! Thank you so much for your contributions!
|
@elgarfo I have updated the changes. Thanks! |
@jkandasa thanks for taking the time to fix this. sorry for not pushing the requested changes, i simply had not enough time before and during the holidays. i guess everything is working well, or did you encounter any difficulties with any browser? |
@elgarfo I tested only on Chrome and I do not face any issue. It was a simple change I made. |
I checked this widget with new SNAPSHOT in Chrome, it works great. |
@wanvo which version of firefox and what OS did u use? can you try with a new firefox profile? |
@elgarfo I am using Windows7 x64, the latest version of Firefox x64. I created a new firefox profile and I tried the widget in it.The menus look the same {{variable}}. Then I returned everything to the original situation. I registered the paths to the css and js files in the local mylib. |
@jkandasa in reference to this thread: https://forum.mycontroller.org/topic/376/custom-widget-send-command-to-node/8
this PR resolves multiple problems which became obvious in the above mentioned thread:
to combat a race condition between angulars bootstrap process, slower internet connections and the process of loading additional JS from local or remote servers, i opted to:
this has been tested so far on windows 10 x64 1806 with firefox 63.0.3 64-bit and is working fine for me.
i've been able to plug your custom slider widget example right into the frontend without modifying app.js. as far as i can tell, the websites is working flawless, on first an subsequent visits, with or without additional modules specified.