refactor: Replace volatile field with Volatile.Read/Write operations

mycroes · Nov 30, 2023 · 69db2ce · 69db2ce
1 parent 390f30b
commit 69db2ce
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Sally7/RequestExecutor/ConcurrentRequestExecutor.cs b/Sally7/RequestExecutor/ConcurrentRequestExecutor.cs
@@ -192,7 +192,7 @@ private class JobPool : IDisposable
         {
             private readonly Channel<int> _jobIdPool;
             private readonly Request[] _requests;
-            private volatile bool _disposed;
+            private bool _disposed;
 
             public JobPool(int maxNumberOfConcurrentRequests)
             {
@@ -212,15 +212,15 @@ public JobPool(int maxNumberOfConcurrentRequests)
 
             public void Dispose()
             {
-                _disposed = true;
+                Volatile.Write(ref _disposed, true);
                 _jobIdPool.Writer.Complete();
             }
 
             public ValueTask<int> RentJobIdAsync(CancellationToken cancellationToken) => _jobIdPool.Reader.ReadAsync(cancellationToken);
 
             public void ReturnJobId(int jobId)
             {
-                if (!_jobIdPool.Writer.TryWrite(jobId) && !_disposed)
+                if (!_jobIdPool.Writer.TryWrite(jobId) && !Volatile.Read(ref _disposed))
                 {
                     Sally7Exception.ThrowFailedToReturnJobIDToPool(jobId);
                 }