Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@nedy js solution #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

@nedy js solution #11

wants to merge 3 commits into from

Conversation

NedyUdombat
Copy link

No description provided.

@NedyUdombat
Implement name concatenation solution
8c6fb76
@NedyUdombat
Implement lottery solution
3daf41b
@NedyUdombat
Implement first set of solutions
99a481a 
Implement type reverse solution

Implement temperature unit conversion solution

Implement multiplication table solution

Implement file reader solution

Implement combine two files solution

Implement rgb color generator  solution

Implement hex color generator  solution

Implement salary classifier  solution

Implement tax classifier  solution

Implement compound Interest calculation solution

Implement convert integermin base to decimal solution

Implement convert decimal to intergaer in given base solution
@mykeels
Copy link
Owner

mykeels commented Jun 11, 2019

  1. Let typeReverse have a "reload" button

  2. The placeholder for the temperature in temperature conversion says 1 or 2 when it should be something like temperature value

  3. The CombineTwoFiles, is supposed to display each line from both files, side by side. Right now, it displays the contents of one file, before the other.

  4. The RGB and Hex color generator should each have a "reload" button

  5. Number in words doesn't seem to work.

image

  1. The Compound Interest is supposed to show the interest for each year, not just the final result

image

@NedyUdombat
Copy link
Author

  1. Let typeReverse have a "reload" button
  2. The placeholder for the temperature in temperature conversion says 1 or 2 when it should be something like temperature value
  3. The CombineTwoFiles, is supposed to display each line from both files, side by side. Right now, it displays the contents of one file, before the other.
  4. The RGB and Hex color generator should each have a "reload" button
  5. Number in words doesn't seem to work.

image

  1. The Compound Interest is supposed to show the interest for each year, not just the final result

image

I will implement this reviews before the end of the week ands update you

@mykeels
Copy link
Owner

mykeels commented Jun 16, 2019

Thanks @NedyUdombat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NedyUdombat @mykeels