Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): hide delivery options position setting when blocks checkout is enabled #1188

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

FlorianSDV
Copy link
Contributor

@FlorianSDV FlorianSDV commented Nov 4, 2024

INT-708

Needs #1189

@FlorianSDV FlorianSDV requested a review from a team as a code owner November 4, 2024 09:42
@FlorianSDV FlorianSDV force-pushed the fix/delivery-options-position-in-checkout branch from 2a4b467 to 693eed5 Compare November 4, 2024 09:44
Copy link

codecov bot commented Nov 4, 2024

❌ 19 Tests Failed:

Tests completed Failed Passed Skipped
243 19 224 0
View the top 3 failed tests by shortest run time
src/components/pdk/components.spec.ts DropOffInput > DropOffInput > emits update:modelValue event
Stack Traces | 0.004s run time
TypeError: Cannot destructure property 'component' of 'props.element' as it is undefined.
 ❯ Module.useDropOffInputContext ../../../node_modules/@.../src/composables/useDropOffInputContext.ts:18:22
 ❯ setup .../components/pdk/WcDropOffInput.vue:50:82
 ❯ callWithErrorHandling ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:200:19
 ❯ setupStatefulComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7811:25
 ❯ setupComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7772:36
 ❯ mountComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5122:7
 ❯ processComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5088:9
 ❯ patch ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:4617:11
 ❯ ReactiveEffect.componentUpdateFn [as fn] ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5232:11
 ❯ ReactiveEffect.run ../../../node_modules/@.../reactivity/dist/reactivity.cjs.js:226:19
src/components/pdk/components.spec.ts DropOffInput > DropOffInput > has prop element
Stack Traces | 0.005s run time
Error: No element found.
 ❯ Module.Je ../../../node_modules/@.../vue-form-builder/dist/index.js:106:11
 ❯ Module.generateFieldId ../../../node_modules/@.../utils/forms/generateFieldId.ts:9:89
 ❯ setup .../components/pdk/WcDropOffInput.vue:52:12
 ❯ callWithErrorHandling ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:200:19
 ❯ setupStatefulComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7811:25
 ❯ setupComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7772:36
 ❯ mountComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5122:7
 ❯ processComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5088:9
 ❯ patch ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:4617:11
 ❯ ReactiveEffect.componentUpdateFn [as fn] ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5232:11
src/components/pdk/components.spec.ts Image > Image > has prop height
Stack Traces | 0.005s run time
AssertionError: expected { …(2) } to have property "height"
 ❯ ../../../node_modules/@.../src/common/runHasPropTest.ts:14:51

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 4, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit c844672
Logs https://github.com/myparcelnl/woocommerce/actions/runs/11745272594
Download https://github.com/myparcelnl/woocommerce/suites/30669561936/artifacts/2163908723

src/Contract/WooCommerceServiceInterface.php Outdated Show resolved Hide resolved
src/Pdk/WcPdkBootstrapper.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the approved (Auto) label Nov 5, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/delivery-options-position-in-checkout branch from 868883b to adb1524 Compare November 6, 2024 10:36
src/Contract/WooCommerceServiceInterface.php Outdated Show resolved Hide resolved
src/Contract/WooCommerceServiceInterface.php Outdated Show resolved Hide resolved
tests/Unit/Hooks/CheckoutScriptHooksTest.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added changes requested (Auto) and removed approved (Auto) labels Nov 6, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/delivery-options-position-in-checkout branch from b714c08 to 1306c35 Compare November 6, 2024 11:19
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ik mis tests

@myparcel-bot myparcel-bot bot force-pushed the fix/delivery-options-position-in-checkout branch 2 times, most recently from 91024b2 to 0bc8421 Compare November 7, 2024 14:08
src/Hooks/CheckoutScriptHooks.php Outdated Show resolved Hide resolved
tests/mock_wc_functions.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot force-pushed the fix/delivery-options-position-in-checkout branch from fdf485e to db737f7 Compare November 8, 2024 15:50
@FlorianSDV FlorianSDV force-pushed the fix/delivery-options-position-in-checkout branch from db737f7 to c844672 Compare November 8, 2024 15:51
@FlorianSDV FlorianSDV changed the title fix(checkout): make it so delivery options is displayed in correct position fix(checkout settings): hide delivery options position settings when blocks checkout is enabled Nov 8, 2024
@EdieLemoine EdieLemoine changed the title fix(checkout settings): hide delivery options position settings when blocks checkout is enabled fix(settings): hide delivery options position setting when blocks checkout is enabled Nov 8, 2024
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Nov 8, 2024
@FlorianSDV FlorianSDV added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit b6115c9 Nov 14, 2024
11 of 13 checks passed
@FlorianSDV FlorianSDV deleted the fix/delivery-options-position-in-checkout branch November 14, 2024 08:57
myparcel-bot bot added a commit that referenced this pull request Dec 17, 2024
## [5.1.0](v5.0.0...v5.1.0) (2024-12-17)

### ⚡ Performance Improvements

* properly externalize delivery options dependency ([9c332e1](9c332e1))

### 🐛 Bug Fixes

* make filters work correctly ([#1189](#1189)) ([239878a](239878a))
* **settings:** hide delivery options position setting when blocks checkout is enabled ([#1188](#1188)) ([b6115c9](b6115c9)), closes [#1189](#1189)
* **webhooks:** prevent webhook callback never being executed ([#1187](#1187)) ([d8cf0bb](d8cf0bb))

### ✨ New Features

* **backend:** add download logs action ([#1175](#1175)) ([ee4cecb](ee4cecb))
* find order by api identifier ([#1214](#1214)) ([a0f76cb](a0f76cb))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 17, 2024

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants