Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make VAT and EORI fields optional for non-EU checkout #1219

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

GravendeelJochem
Copy link
Contributor

INT-778
Make VAT and EORI fields optional for non-EU checkout

@GravendeelJochem GravendeelJochem requested a review from a team as a code owner December 20, 2024 08:54
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 20, 2024

PDK upgrade summary

♻️ The following packages were upgraded (from cache):

Package Old version New version
myparcelnl/pdk 2.48.0 2.49.1

Copy link

codecov bot commented Dec 20, 2024

❌ 19 Tests Failed:

Tests completed Failed Passed Skipped
242 19 223 0
View the top 3 failed tests by shortest run time
src/components/pdk/components.spec.ts DropOffInput > DropOffInput > emits update:modelValue event
Stack Traces | 0.005s run time
TypeError: Cannot destructure property 'component' of 'props.element' as it is undefined.
 ❯ Module.useDropOffInputContext ../../../node_modules/@.../composables/components/useDropOffInputContext.ts:18:22setup .../components/pdk/WcDropOffInput.vue:50:82callWithErrorHandling ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:200:19setupStatefulComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7811:25setupComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7772:36mountComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5122:7processComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5088:9patch ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:4617:11ReactiveEffect.componentUpdateFn [as fn] ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5232:11ReactiveEffect.run ../../../node_modules/@.../reactivity/dist/reactivity.cjs.js:226:19
src/components/pdk/components.spec.ts DropOffInput > DropOffInput > has prop element
Stack Traces | 0.005s run time
Error: No element found.
 ❯ Module.Je ../../../node_modules/@.../vue-form-builder/dist/index.js:106:11Module.generateFieldId ../../../node_modules/@.../utils/forms/generateFieldId.ts:9:89
setup .../components/pdk/WcDropOffInput.vue:52:12callWithErrorHandling ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:200:19setupStatefulComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7811:25setupComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7772:36mountComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5122:7processComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5088:9patch ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:4617:11ReactiveEffect.componentUpdateFn [as fn] ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5232:11
src/components/pdk/components.spec.ts Image > Image > has prop height
Stack Traces | 0.005s run time
AssertionError: expected { …(2) } to have property "height"
 ❯ ../../../node_modules/@.../src/common/runHasPropTest.ts:14:51

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@FreekVR
Copy link
Collaborator

FreekVR commented Dec 20, 2024

Ziet er OK uit, maar is nu niet specifiek voor buiten de EU maar dus altijd. Weet functioneel niet of dat wenselijk is? @RichardPerdaan

@myparcel-bot myparcel-bot bot force-pushed the fix/eori-vat-field-requirement branch from 560f435 to d588b34 Compare December 23, 2024 12:53
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 23, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit a0a335c
Logs https://github.com/myparcelnl/woocommerce/actions/runs/12601998951
Download https://github.com/myparcelnl/woocommerce/suites/32656797064/artifacts/2383886363

@RichardPerdaan
Copy link
Member

Ziet er OK uit, maar is nu niet specifiek voor buiten de EU maar dus altijd. Weet functioneel niet of dat wenselijk is? @RichardPerdaan

@FreekVR Dat is prima, de velden verschijnen alleen bij de landen buiten de EU

@myparcel-bot myparcel-bot bot force-pushed the fix/eori-vat-field-requirement branch from d588b34 to ae84ec2 Compare January 3, 2025 10:57
@myparcel-bot myparcel-bot bot force-pushed the fix/eori-vat-field-requirement branch from ae84ec2 to a0a335c Compare January 3, 2025 18:13
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jan 6, 2025
@joerivanveen joerivanveen disabled auto-merge January 9, 2025 12:51
@joerivanveen joerivanveen merged commit 1950afa into main Jan 9, 2025
8 checks passed
@joerivanveen joerivanveen deleted the fix/eori-vat-field-requirement branch January 9, 2025 12:51
myparcel-bot bot added a commit that referenced this pull request Jan 30, 2025
## [5.3.0](v5.2.0...v5.3.0) (2025-01-30)

### 🐛 Bug Fixes

* Make VAT and EORI fields optional for non-EU checkout ([#1219](#1219)) ([1950afa](1950afa))

### ✨ New Features

* add toggle for EU VAT and EORI fields in checkout settings ([#1227](#1227)) ([4064129](4064129))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Jan 30, 2025

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants