Validate GUID in Uploader

myrotvorets · Sep 26, 2023 · 754c20b · 754c20b
1 parent 3235444
commit 754c20b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/services/upload.mts b/src/services/upload.mts
@@ -20,6 +20,10 @@ export class UploadService {
     }
 
     public static filenameByGuid(guid: string, ext = '.jpg'): string {
+        if (!/^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$/u.test(guid)) {
+            throw new TypeError(`GUID is not valid: ${guid}`);
+        }
+
         const hashedPath = UploadService.hashFileName(guid);
         const filename = `${guid}${ext}`;
         return join(hashedPath, filename);

diff --git a/test/unit/services/upload.test.mts b/test/unit/services/upload.test.mts
@@ -117,5 +117,9 @@ describe('UploadService', function () {
             const actual = service.filenameByGuid(input, '');
             expect(actual).to.equal(expected);
         });
+
+        it('should reject invalid input', function () {
+            expect(() => service.filenameByGuid('guid', '')).to.throw(TypeError);
+        });
     });
 });