Merge pull request #937 from myrotvorets/renovate/linters

chore(deps): update dependency @myrotvorets/eslint-config-myrotvorets-ts to ^2.22.4

package.json

@@ -37,7 +37,7 @@
     "sharp": "^0.32.6"
   },
   "devDependencies": {
-    "@myrotvorets/eslint-config-myrotvorets-ts": "^2.21.0",
+    "@myrotvorets/eslint-config-myrotvorets-ts": "^2.22.4",
     "@types/chai": "^4.3.7",
     "@types/chai-as-promised": "^7.1.6",
     "@types/chai-subset": "^1.3.3",

src/controllers/upload.mts

@@ -26,7 +26,7 @@ async function searchUploadHandler(
     res: Response<UploadResponse>,
     next: NextFunction,
 ): Promise<void> {
-    const file = (req.files as Express.Multer.File[])[0];
+    const file = (req.files as Express.Multer.File[])[0]!;
     const { guid } = req.params;
 
     await UploadService.uploadFile(file, guid);

src/server.mts

@@ -1,6 +1,6 @@
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import express, { type Express, json, static as staticMiddleware } from 'express';
+import express, { type Express, json } from 'express';
 import { installOpenApiValidator } from '@myrotvorets/oav-installer';
 import { errorMiddleware, notFoundMiddleware } from '@myrotvorets/express-microservice-middlewares';
 import { cleanUploadedFilesMiddleware } from '@myrotvorets/clean-up-after-multer';
@@ -18,22 +18,6 @@ import { uploadErrorHandlerMiddleware } from './middleware/upload.mjs';
 export async function configureApp(app: express.Express): Promise<void> {
     const env = environment();
 
-    /* c8 ignore start */
-    if (env.NODE_ENV !== 'production') {
-        app.use(
-            '/specs/',
-            staticMiddleware(join(dirname(fileURLToPath(import.meta.url)), 'specs'), {
-                acceptRanges: false,
-                index: false,
-            }),
-        );
-
-        if (process.env.HAVE_SWAGGER === 'true') {
-            app.get('/', (_req, res) => res.redirect('/swagger/'));
-        }
-    }
-    /* c8 ignore end */
-
     app.use(json());
 
     await installOpenApiValidator(

src/services/upload.mts

@@ -1,16 +1,22 @@
 import { mkdir } from 'node:fs/promises';
+import { tmpdir } from 'node:os';
 import { join, sep } from 'node:path';
 import sharp from 'sharp';
 
+type UploadedFileInternal =
+    | (Pick<Express.Multer.File, 'path' | 'destination'> & { buffer: undefined })
+    | (Pick<Express.Multer.File, 'buffer'> & { path: undefined; destination: undefined });
+
+type UploadedFile = Pick<Express.Multer.File, 'path' | 'destination' | 'buffer'>;
+
+// eslint-disable-next-line @typescript-eslint/no-extraneous-class
 export class UploadService {
-    public static async uploadFile(
-        file: Pick<Express.Multer.File, 'path' | 'destination' | 'buffer'>,
-        guid: string,
-    ): Promise<string> {
-        const img = await UploadService.prepareFile(file.path ?? file.buffer); // memoryStorage() returns Buffer
+    public static async uploadFile(file: UploadedFile, guid: string): Promise<string> {
+        const f = file as unknown as UploadedFileInternal;
+        const img = await UploadService.prepareFile(f.path ?? f.buffer); // memoryStorage() returns Buffer
         const hashedPath = UploadService.hashFileName(guid);
         const filename = `${guid}.jpg`;
-        const destPath = join(file.destination ?? '', hashedPath); // No file.destination for memoryStorage()
+        const destPath = join(f.destination ?? tmpdir(), hashedPath); // No file.destination for memoryStorage()
         const destJpeg = join(destPath, filename);
 
         await mkdir(destPath, { recursive: true, mode: 0o755 });

tsconfig.json

@@ -13,6 +13,10 @@
         "noUnusedLocals": true,
         "noUnusedParameters": false,
         "noFallthroughCasesInSwitch": true,
+        "noPropertyAccessFromIndexSignature": true,
+        "noUncheckedIndexedAccess": true,
+        "noImplicitOverride": true,
+        "noImplicitReturns": true,
         "esModuleInterop": true,
         "resolveJsonModule": true
     },