Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7876] Fix embedded attachment processing #7878

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

gbp
Copy link
Member

@gbp gbp commented Aug 29, 2023

Relevant issue(s)

Fixes #7876

What does this do?

Fix embedded attachment processing

Why was this needed?

For attachments which are embedded within a RFC822 attachment, were unable process some attachment if they were received a long time ago.

This is down to changes in the underlying mail gem which results in slight difference in the headers which get appended to the attachment body.

This change fixes this by only matching against the body of embedded attachments, ignoring headers and any slight changes.

@gbp gbp force-pushed the 7876-fix-emebeded-attachment-processing branch 3 times, most recently from 70e496e to 0e7479c Compare August 29, 2023 16:18
For attachments which are embedded within a RFC822 attachment, were
unable process some attachment if they were received a long time ago.

This is down to changes in the underlying mail gem which results in
slight difference in the headers which get appended to the attachment
body.

This change fixes this by only matching against the body of embedded
attachments, ignoring headers and any slight changes.

Fixes #7876
@gbp gbp force-pushed the 7876-fix-emebeded-attachment-processing branch from 0e7479c to d368e2d Compare August 29, 2023 16:20
@gbp gbp merged commit eb31273 into develop Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken attachment masking - attachments embedded within RFC822
1 participant