Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5851] Review new framework defaults #8120

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

gbp
Copy link
Member

@gbp gbp commented Feb 5, 2024

Relevant issue(s)

Fixes #5851

What does this do?

Lazy review of the new framework defaults. Testing to see if the specs pass with the new defaults used.

Why was this needed?

So we can upgrade Rails further.

@gbp gbp marked this pull request as draft February 5, 2024 10:01
@gbp gbp force-pushed the review-new-framework-defaults branch from 4ed6ccb to 3af87a4 Compare April 16, 2024 09:03
@gbp gbp added the on-staging label Apr 16, 2024
@gbp gbp marked this pull request as ready for review April 16, 2024 11:03
@gbp
Copy link
Member Author

gbp commented Apr 16, 2024

This is on deployed to staging. I'm thinking this might be good to merge but will see if there are issues when testing other features on there.

@gbp gbp removed the on-staging label Apr 30, 2024
@@ -31,6 +31,7 @@ class Application < Rails::Application
#
# config.time_zone = "Central Time (US & Canada)"
# config.eager_load_paths << Rails.root.join("extras")
config.load_defaults = 7.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't doing anything - we need to call the #load_defaults method!

Suggested change
config.load_defaults = 7.0
config.load_defaults 7.0

@gbp gbp marked this pull request as draft August 14, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review new framework defaults
1 participant