Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codespace secrets approach #1798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ajparsons
Copy link
Contributor

Features like the donate page and election lookup need external API keys, which doesn't work nicely with the docker setup because the conf/general is recreated each time the docker is opened (rather than created).

This PR:

  • Adjusts docker setup so that system environmental variables populate the conf/general file.
  • Adjust 'devcontainer.json' to prompt codespaces users to setup the (optional) keys in their user codespace secrets store.

image

@ajparsons ajparsons requested a review from dracos June 18, 2024 14:42
@dracos dracos force-pushed the master branch 3 times, most recently from 2c2b1cc to ccc444c Compare July 5, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant