-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Stripe library/API version to current #1800
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny question but assuming that's fine it looks good.
]; | ||
if ($form_data['coupon']) { | ||
$args['coupon'] = $form_data['coupon']; | ||
} elseif ($this->stripe->discount) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is just saying if there was a discount and there is no longer a discount then clear the discount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, exactly, I think update only changes the things you provide.
8032e44
to
bd82074
Compare
Use the new Subscription Schedules so that downgrade will only apply from the next billing period.
2c2b1cc
to
ccc444c
Compare
Similar (hopefully identical?) to mysociety/mapit.mysociety.org#158
so we can get on current Stripe API version, and improve downgrade behaviour.