Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activities - update handling status #1334

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Activities - update handling status #1334

merged 1 commit into from
Jun 24, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 20, 2023

This PR changes the way how to handle ActivityStatus

  1. Manually setting otel.status_code and otel.status_description is no longer needed. System.Diagnostics.DiagnosticSource v6+ handles it natively. Ref: Support Status and StatusDescription from Activity class open-telemetry/opentelemetry-dotnet#2569
  2. Avoid setting spanstasus.ok. The unset value is preferred one https://opentelemetry.io/docs/concepts/signals/traces/#span-status
  3. Removed unused fields/constants.
  4. Conditional compilation simplified - it should work on any .NET version. As long as it is referencing System.Diagnostics.DiagnosticSource v6+

@Kielek
Activities - update handling status
9b57d39 
Signed-off-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
@Kielek Kielek force-pushed the activities-handle-status branch from c739359 to 9b57d39 Compare June 20, 2023 08:19
@Kielek Kielek marked this pull request as ready for review June 20, 2023 08:30
pellared
pellared approved these changes Jun 20, 2023
View reviewed changes
Copy link

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as an OTel .NET approver.

@Kielek Kielek mentioned this pull request Jun 21, 2023
Merged
3 tasks
@bgrainger
Copy link
Member

Thanks for the improvement!

@bgrainger bgrainger merged commit d354b8e into mysql-net:master Jun 24, 2023
@Kielek Kielek deleted the activities-handle-status branch June 25, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kielek @bgrainger @pellared