Add Synchronous to MySqlConnectionStringBuilder. #21
Conversation
| if (!Synchronous) | ||
| return task; | ||
|
|
||
| return new ValueTask<T>(task.AsTask().GetAwaiter().GetResult()); |
There was a problem hiding this comment.
Should this have an optimised code path for the case where the ValueTask already has a value (which is expected to be common, hence the use of ValueTask)?
There was a problem hiding this comment.
Maybe .AsTask() returns a completed task efficiently; but still there is unnecessary allocation.
There was a problem hiding this comment.
Yes, that would be a great change.
|
I'm not convinced I like this approach. I haven't attempted it, but it feels like one could make the socket operations synchronous, then use This ties into an improvement I want to make to use all new non-public methods that return |
bgrainger
force-pushed
the
master
branch
5 times, most recently
from
eb9bbeb
to
7754ffa
Compare
|
I don't like it either, but I wasn't ready to do the hard work of using synchronous socket operations. This is just a proof of concept that may encourage someone to eventually do it right. :-) |
Setting Synchronous to true forces async requests to block on the calling thread to improve debugging.
|
Rebased. |
Turned out to not be that hard; code is referenced from #62. I'm going to close this PR in favour of (the eventual resolution of) that one. |
This initial implementation could have adverse affects on performance, so you might not want to merge, but it is an idea for enforcing synchronous access, even when using the async methods, to improve debugging.