-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new rule: require an explanation comment for all disable directives #29
Labels
Comments
Thank you for your suggestion. Sounds a good idea. |
For reference, there is a related RFC: eslint/rfcs#33 |
that's an awesome RFC! |
Now that the RFC has been implemented in ESLint 7.0.0 and an explanation comment is possible on the same line, should this issue become "new rule: require an explanation comment in disable directives"? |
bradzacher
changed the title
new rule: require an explanation comment preceding disable comments
new rule: require an explanation comment for all disable directives
May 11, 2020
mysticatea
pushed a commit
that referenced
this issue
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's way too easy to disable eslint rules. I don't want to disable them completely though, because sometimes you need to work around a rule.
I'd love to raise the bar so that there must be an explanation comment with the disable.
This makes it easier to review PRs, and means that people can remember why a rule was disabled "way back when" instead of potentially being fixed.
The text was updated successfully, but these errors were encountered: