💥 add check of bigint literal property names to node/no-unsupported-f…

…eatures/es-syntax
mysticatea · Dec 26, 2019 · fb9ce15 · fb9ce15
1 parent 4f74fbf
commit fb9ce15
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/lib/rules/no-unsupported-features/es-syntax.js b/lib/rules/no-unsupported-features/es-syntax.js
@@ -362,6 +362,16 @@ const features = {
                 test: info => info.node.type === "Literal",
                 messageId: "no-bigint",
             },
+            {
+                supported: null,
+                test: ({ node }) =>
+                    node.type === "Literal" &&
+                    (node.parent.type === "Property" ||
+                        node.parent.type === "MethodDefinition") &&
+                    !node.parent.computed &&
+                    node.parent.key === node,
+                messageId: "no-bigint-property-names",
+            },
         ],
     },
     dynamicImport: {
@@ -615,6 +625,8 @@ module.exports = {
             //------------------------------------------------------------------
             "no-bigint":
                 "Bigint literals are not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
+            "no-bigint-property-names":
+                "Bigint literal property names are not supported yet.",
             "no-dynamic-import":
                 "'import()' expressions are not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
         },

diff --git a/tests/lib/rules/no-unsupported-features/es-syntax.js b/tests/lib/rules/no-unsupported-features/es-syntax.js
@@ -2450,6 +2450,14 @@ ruleTester.run(
                     code: "var n = new BigUint64Array()",
                     options: [{ version: "10.3.0" }],
                 },
+                {
+                    code: "var n = { [0n]: 0 }",
+                    options: [{ version: "10.4.0" }],
+                },
+                {
+                    code: "var n = class { [0n]() {} }",
+                    options: [{ version: "10.4.0" }],
+                },
             ],
             invalid: [
                 {
@@ -2465,6 +2473,32 @@ ruleTester.run(
                         },
                     ],
                 },
+                {
+                    code: "var n = { 0n: 0 }",
+                    options: [{ version: "12.0.0" }],
+                    errors: [
+                        {
+                            messageId: "no-bigint-property-names",
+                            data: {
+                                supported: null,
+                                version: "12.0.0",
+                            },
+                        },
+                    ],
+                },
+                {
+                    code: "var n = class { 0n() {} }",
+                    options: [{ version: "12.0.0" }],
+                    errors: [
+                        {
+                            messageId: "no-bigint-property-names",
+                            data: {
+                                supported: null,
+                                version: "12.0.0",
+                            },
+                        },
+                    ],
+                },
             ],
         },
         {