Added replace method on Delorean object #81
Conversation
|
docs? :) |
|
Ah yes, sorry forgot. Let me get to that. On Sat, Mar 12, 2016 at 2:22 AM, Mahdi Yusuf notifications@github.com
Abu Ashraf Masnun | +8801711960803 | http://masnun.me |
|
I added the docs. Please review. |
| self.assertEqual(do.replace(minute=23).datetime.minute, 23) | ||
| self.assertEqual(do.replace(second=45).datetime.second, 45) | ||
|
|
||
|
|
There was a problem hiding this comment.
I would also like to see a few asserts on the entire datetime object as well and also assuring the timezone is unchanged.
|
I added a test showing that the timezone doesn't change. And a test using datetime arithmetic with timedelta. |
|
And a few asserts on the datetime objects. |
|
Is there anything else you would like me to help with? |
|
I just need a moment to look it over. I will try to get to it before this weekend. |
|
Hi, just checking how it looks. Did you manage to get a look at it? |
|
Awesome thanks for contribution. Sorry for my terrible delay. |
|
No problem :-) On Friday, September 16, 2016, Mahdi Yusuf notifications@github.com wrote:
Abu Ashraf Masnun | +8801711960803 | http://masnun.me |
As discussed in #80 - please review and let me know if there needs to be further modifications.