fixes test regex #16
Closed
fixes test regex #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jbuffin thanks! I believe the single quote is necessary on unix-like machines according to mochajs/mocha#1115 How about making it a separate npm job like:
|
|
I guess the question is do you want to have a windows-only npm script? It would work but if that script ever changed, it would need to be changed twice. Is that something you are OK with? |
|
Good point, thanks for pointing out it! I think we should add the Windows related settings into README and leave only one testing job in I'm going to close this PR. Thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests do not currently work (at least on windows)
This will fix the target regex, removing the unnecessary single-quotes.