2.4.0 Filter/Subfilter Overall, tmdb_director, and tmdb_writer

[meisnate12]

[2.4.0] - 2020-11-03

Added

• Bug: New in v2.0.0, Shows no longer match, "unknown filter category" #63 - Added plex_search to AND searches together
• Added additional filters and allow for use of .not for inverse filters
• TMDB Directors? #75 - Added tmdb_director and tmdb_writer which function the same as tmdb_actor but for directors and writers
• More compatibility with previous config files.

Changed

• Bug: New in v2.0.0, Shows no longer match, "unknown filter category" #63 - Plex Filters are now listed and have been tested and have been changed to Plex Searches
• subfilters are now listed and have been tested and have been changed to filters

Fixed

• collection_order was in the code as collection_sort
• Upgrade PlexAPI dependency to 4.2.0

[burkasaurusrex]

We should just phase out PyYAML altogether in favor of raumel.yaml to avoid two dependencies for similar functionality

[meisnate12]

where do we use PyYAML?

[burkasaurusrex]

Actually, @mza921 it looks like you may have introduced ruamel.yaml? Is there a preference over PyYAML? I don't have an opinion, but we should standardize on one throughout the project I think.

[mza921]

I use ruamel.yaml for updating the config file during initial Trakt authorization. Research had led me to this. I prefer it over PyYAML but didn't bother to update the other modules since I mostly worked on Trakt integration.

[burkasaurusrex]

Ok, let's default to ruamel.yaml then and remove PyYAML. It looks like it's only used in a couple of places:

• Plex-Auto-Collections/app/config_tools.py

  Line 80 in 8d129ad

  self.data = yaml.load(yml, Loader=yaml.FullLoader)

• Plex-Auto-Collections/app/config_tools.py

  Line 455 in 8d129ad

  yaml.dump(config.data, f)

• Plex-Auto-Collections/app/radarr_tools.py

  Line 1 in 8d129ad

  import re, requests, os, yaml

  (looks like this import can just be deleted)

[meisnate12]

keep this open for now i found a silent breaking bug

[mza921]

1. Yes, let's change subfilters
2. Yes, change Plex filters to search. Will users now have to specify plex_search as a list type or is it implied?

collections:
  Dave Chappelle:
    plex_search:
      - actor: Dave Chappelle

3. Just use filters. Good point about global_filters being misleading, since these are scoped at the collection level after all list types are combined.

While I think these are the best way forward, they do break compatibility with existing config files. We need to make sure that the interactive mode also works with these changes.

[meisnate12]

So I'm thinking I'll be able to have it not break the old configs but it will instead give a warning for any attribute deprecated saying that it will be run as the proper attribute

I hadn't thought about plex_search being a whole category but I'm not mad at it we could make everything under one search AND together and then multiple plex_searches OR together and take out the and. Completely

[meisnate12]

Also I don't think I've ever used interactive mode lol but I'll start testing it as well

[meisnate12]

ok introducing plex_search let me know what yall think?

[meisnate12]

Oh this version should work with any version of the config i put checks in for all the old attributes

[mza921]

Thanks for all the updates.

[meisnate12]

no problem I like this script and want to see it improved plus learning python in the process is a great bonus

Btw just push your changes for the new movie Agent and ill get this pull rebased on them the same day so this can go out shortly after

[mza921]

Can we keep undocumented support for decade?

[meisnate12]

well i took out decade in favor of the year range i added just do year: 1990-1999 i can add it back in if needed but i figured the range would be less confusing and not bog down the user with another option plus the range isn't limited to 10 years either

[meisnate12]

Did you want me to add decade back or is year range ok?

[mza921]

I prefer to keep it

[meisnate12]

ok ill add it back silently

[meisnate12]

@mza921 my pull is now rebased on 2.3.0 and i upgraded my release to 2.4.0

[mza921]

I'm confused about this. So if plex_search does an AND, how do I do an OR? How would this README example work:

collections:
  90s Movies:
    plex_search:
      year:
        - 1990
        - 1991
        - 1992
        - 1993
        - 1994
        - 1995
        - 1996
        - 1997
        - 1998
        - 1999

[meisnate12]

it ANDs different attributes and ORs multiples of the same attribute I can try and clarify that in the readme. The program will also tell you exactly how it's searching so for your example it would look like this:

| Processing Plex Search: year(1990 OR 1991 OR 1992 OR 1993 OR 1994 OR 1995 OR 1996 OR 1997 OR 1998 OR 1999)

it will show each AND on the subsequent lines

if you want to AND the same attribute you have to use subfilters

[mza921]

Got it. Nice addition to report the actual query.

[mza921]

Can you rebase on 2.3.1? Then we're good to go.

[meisnate12]

can do give me a minute

[meisnate12]

ok were good to go i also updated the changelog to include issue and pull numbers for easier tracking