2.4.2 Fixes for #87 and #89 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mza921
reviewed
Nov 5, 2020
| @@ -38,10 +38,10 @@ def imdb_get_movies(config_path, plex, data): | |||
| "//a/img//@data-tconst") | |||
| if "/search/" in imdb_url: | |||
| results = re.search('<span>\\d+-\\d+ of \\d+ titles.</span>', str(r.content)) | |||
| total = 100 if results is None else re.findall('(\\d+)', results.group(0))[2] | |||
| total = 100 if results is None else re.findall('(\\d+)', results.group(0).replace(',', ''))[2] | |||
There was a problem hiding this comment.
In the future, should we just set the size as a parameter and add it to the URL on the user's behalf?
There was a problem hiding this comment.
i mean this solution should work and then if the list changes its total the user would have to constantly update the total
mza921
approved these changes
Nov 5, 2020
This was
linked to
issues
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.4.2] - 2020-11-04
Fixed