Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: remove error for Hall and Arnoldi combination #104

Merged
merged 5 commits into from
Jul 27, 2022

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented Jul 27, 2022

PR description

  • Improved warning messages if Arnoldi iteration fails
  • Added single QR and shift-invert regression tests for Hall + electron inertia setups

Bugfixes

Legolas

  • Removed the error thrown when combining Hall + Arnoldi solvers

@n-claes n-claes added bug Something isn't working tests-regression Modified or new regression tests labels Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #104 (dc3fa0e) into develop (5acf1a3) will decrease coverage by 1.44%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
- Coverage    90.19%   88.74%   -1.45%     
===========================================
  Files          112      112              
  Lines         6476     6470       -6     
===========================================
- Hits          5841     5742      -99     
- Misses         635      728      +93     
Flag Coverage Δ
legolas 91.04% <100.00%> (-2.09%) ⬇️
pylbo 83.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes merged commit 2819e9e into develop Jul 27, 2022
@n-claes n-claes deleted the fix/hall_warnings branch December 8, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests-regression Modified or new regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant