Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of new cooling curves #137

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Addition of new cooling curves #137

merged 3 commits into from
Apr 27, 2023

Conversation

jordidj
Copy link
Collaborator

@jordidj jordidj commented Apr 24, 2023

PR description

Addition of the colgan_dm cooling curve and its constituent curves colgan and dalgarno2

New features

Legolas

  • Three new cooling curves: colgan, dalgarno2, colgan_dm

Bugfixes

Unit tests

  • Missing initialisation statement in spex_dalgarno_below

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

@n-claes n-claes added the feature Implementation of a new feature label Apr 24, 2023
@n-claes n-claes added this to the Legolas 2.0 milestone Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #137 (77b5c08) into develop (6a2f6da) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #137      +/-   ##
===========================================
+ Coverage    90.68%   90.69%   +0.01%     
===========================================
  Files          158      158              
  Lines         8952     8965      +13     
===========================================
+ Hits          8118     8131      +13     
  Misses         834      834              
Flag Coverage Δ
legolas 93.13% <100.00%> (+0.01%) ⬆️
pylbo 86.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Co-authored-by: Niels Claes <niels.claes@live.be>
@n-claes n-claes force-pushed the feature/cooling_curves branch from be70a6d to 77b5c08 Compare April 27, 2023 10:31
@n-claes n-claes changed the title Feature/cooling curves Addition of new cooling curves Apr 27, 2023
@n-claes n-claes merged commit 9fd0bdc into develop Apr 27, 2023
@n-claes n-claes deleted the feature/cooling_curves branch April 27, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants