Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper treatment of pure heating/cooling #145

Merged
merged 7 commits into from
May 31, 2023
Merged

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented May 31, 2023

PR description

This PR ensures that pure heating and/or cooling through custom-defined functions behaves as expected.
In short:

  • Ensures that heating without cooling is checked when adding non-adiabatic matrix elements; this was not the case previously.
  • The default cooling curve is now "nothing" (docs have been updated), to prevent unnecessary table initialisations and interpolations for cases in which a custom cooling function is provided.
  • Prevents setting custom functions when the corresponding physical effect is not enabled.
  • Throw an error if thermal balance is enforced but heating is disabled.
  • Sanity checks are now in place when treating forced thermal balance.
  • New unit tests for these particular cases are now in place.

Bugfixes

Legolas

@n-claes n-claes added bug Something isn't working legolas-backend Under-the-hood changes to Legolas tests-unit Modified or new unit tests docs Documentation related stuff labels May 31, 2023
@n-claes n-claes linked an issue May 31, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #145 (ecfa5a3) into develop (2a94ba9) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #145      +/-   ##
===========================================
+ Coverage    90.78%   90.79%   +0.01%     
===========================================
  Files          159      159              
  Lines         9050     9086      +36     
===========================================
+ Hits          8216     8250      +34     
- Misses         834      836       +2     
Flag Coverage Δ
legolas 93.11% <83.33%> (+<0.01%) ⬆️
pylbo 86.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes merged commit c5851ff into develop May 31, 2023
@n-claes n-claes deleted the bugfix/144 branch May 31, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related stuff legolas-backend Under-the-hood changes to Legolas tests-unit Modified or new unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pure heating/cooling does not work as expected
1 participant