Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a dynamic state vector #93

Merged
merged 6 commits into from
Jul 4, 2022
Merged

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented Mar 7, 2022

PR description

This PR introduces a dynamic state vector instead of a length-8 hardcoded vector with perturbed variables.

  • separate module mod_get_indices added with index retrieval functions
  • boundary conditions: indices are no longer hardcoded but retrieved based on the state vector variable.
  • refactored matrix_gridpts to dim_matrix

@n-claes n-claes added legolas-backend Under-the-hood changes to Legolas refactor Refactoring existing code labels Mar 7, 2022
@n-claes n-claes self-assigned this Mar 7, 2022
@n-claes n-claes force-pushed the feature/dynamic_state_vector branch from a61c763 to 575e6f2 Compare March 7, 2022 11:36
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #93 (1d88f94) into develop (6506f79) will increase coverage by 0.15%.
The diff coverage is 85.54%.

@@             Coverage Diff             @@
##           develop      #93      +/-   ##
===========================================
+ Coverage    88.17%   88.33%   +0.15%     
===========================================
  Files          102      103       +1     
  Lines         6082     6111      +29     
===========================================
+ Hits          5363     5398      +35     
+ Misses         719      713       -6     
Flag Coverage Δ
legolas 90.61% <85.54%> (+0.21%) ⬆️
pylbo 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes force-pushed the feature/dynamic_state_vector branch from 575e6f2 to 1d88f94 Compare July 4, 2022 13:13
@n-claes n-claes added this to the Legolas 2.0 milestone Jul 4, 2022
@n-claes n-claes merged commit 2519c7e into develop Jul 4, 2022
@n-claes n-claes deleted the feature/dynamic_state_vector branch July 4, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legolas-backend Under-the-hood changes to Legolas refactor Refactoring existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant