Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative Hall implementation and documentation update #96

Merged
merged 6 commits into from
Jun 27, 2022
Merged

Alternative Hall implementation and documentation update #96

merged 6 commits into from
Jun 27, 2022

Conversation

jordidj
Copy link
Collaborator

@jordidj jordidj commented Jun 16, 2022 •
edited
Loading

PR description

Two implementations of the Hall term are available now.

New features

Legolas

  • Rather than using the Hall implementation as described in the paper, one can opt for a straight implementation of the JxB Hall expression in the induction equation.

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

@jordidj
Copy link
Collaborator Author

jordidj commented Jun 16, 2022 •
edited
Loading

To do: add multirun test (log k variation) for elec_inertia

@n-claes n-claes added feature Implementation of a new feature docs Documentation related stuff labels Jun 20, 2022
@n-claes n-claes merged commit 6506f79 into develop Jun 27, 2022
@n-claes n-claes deleted the dev_hmhd branch June 27, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-claes n-claes n-claes approved these changes

Assignees
No one assigned
Labels
docs Documentation related stuff feature Implementation of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordidj @n-claes