Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize Iroh, publish to docker hub as part of CI #1371

Closed
b5 opened this issue Aug 17, 2023 · 1 comment · Fixed by #2520
Closed

Dockerize Iroh, publish to docker hub as part of CI #1371

b5 opened this issue Aug 17, 2023 · 1 comment · Fixed by #2520
Assignees
@Arqu
Labels
ops operational infrastructure (hardware, deployments) concerns, excluding continuous integration
Milestone
v0.21.0

Comments

@b5
Copy link
Member

b5 commented Aug 17, 2023

Seems like a no-brainer, would really help ease the installation process for folks running containers.

I think we should build from a small, but functional base image like alpine or something that has a filesystem. We've used distroless in the past, but think it has less utility here.
@b5 b5 added the ops operational infrastructure (hardware, deployments) concerns, excluding continuous integration label Aug 17, 2023
@b5 b5 modified the milestones: v0.6.0-alpha: Sync!, v0.6.1 Aug 17, 2023
@b5 b5 removed this from the v0.6.0 milestone Sep 5, 2023
@dignifiedquire dignifiedquire added this to the v0.21.0 milestone Jul 17, 2024
@dignifiedquire
Copy link
Contributor

Dockerfile is done: https://github.com/n0-computer/iroh/tree/main/docker

This was referenced Jul 17, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 18, 2024
@Arqu
feat(ci): publish docker images (#2520)
c0fa1f4 
## Description

Tested here:
https://github.com/n0-computer/iroh/actions/runs/9992457651/job/27617587850?pr=2520
Results here: 
- https://hub.docker.com/r/n0computer/iroh
- https://hub.docker.com/r/n0computer/iroh-relay
- https://hub.docker.com/r/n0computer/iroh-dns-server

Will only trigger on new releases.
Pretty happy, images are very slim and builds are pretty snappy.

Test it out with 
`docker run -p 9090:9090 -p 4919:4919/udp -Pit n0computer/iroh:latest
--rpc-addr 0.0.0.0:4919 start`

Closes #1371

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->


## Change checklist

- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arqu Arqu

Labels
ops operational infrastructure (hardware, deployments) concerns, excluding continuous integration
Projects
iroh
Archived in project
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

feat(ci): publish docker images n0-computer/iroh
3 participants
@dignifiedquire @b5 @Arqu