upgrade to quinn@0.11 & rustls@0.23 #2273
Comments
|
Can I help move this along somehow? |
It's currently in the mode of making the test suite pass. All "changes" should be done and it is "just" debugging. So the work right now is: run test suite, pick most promising failing test, debug it, push fix, run test suite again to see if more failures are magically fixed, pick next test. But most test failures have just been fixes in the test suite, so progress has been slow. |
## Description Upgrades the Quinn and Rustls dependencies. This touches a lot of dependencies and affects a lot of the internal API due to the changes in Quinn. ## Breaking Changes - `iroh::net::endpoint::Endpoint::accept` now returns `Incoming` instead of `Connecting`. This allows rejecting incoming connections earlier, notify the initiating side to retry later and more. To get back `Connecting`, simply use `Incoming::accept()`. If all you did with `Connecting` before was to `.await` it, you can do the same with `Incoming`, too, and get back a `Connection`. - Removed `iroh::net::endpoint::Builder::concurrent_connections`. The amount of concurrent connections is now controlled by either calling `Incoming::accept` or `Incoming::refuse` after `Endpoint::accept`. ## Notes & open questions See #2273 for the tracking issue coordinating all this work. This is the last piece of the puzzle. ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <me@dignifiedquire.com> Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
|
Closed by #2595 |
## Description Upgrades the Quinn and Rustls dependencies. This touches a lot of dependencies and affects a lot of the internal API due to the changes in Quinn. ## Breaking Changes - `iroh::net::endpoint::Endpoint::accept` now returns `Incoming` instead of `Connecting`. This allows rejecting incoming connections earlier, notify the initiating side to retry later and more. To get back `Connecting`, simply use `Incoming::accept()`. If all you did with `Connecting` before was to `.await` it, you can do the same with `Incoming`, too, and get back a `Connection`. - Removed `iroh::net::endpoint::Builder::concurrent_connections`. The amount of concurrent connections is now controlled by either calling `Incoming::accept` or `Incoming::refuse` after `Endpoint::accept`. ## Notes & open questions See #2273 for the tracking issue coordinating all this work. This is the last piece of the puzzle. ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <me@dignifiedquire.com> Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
WIP branch: https://github.com/n0-computer/iroh/tree/dig/quinn11
dig/quinn11branch needs to work and pass all testsOnce the basics work, we need to make it good:
Nice to have:
=0.25.0-alpha.2Outstanding issues:
Bytes, but @0.11 gives us a&[u8]and we end up copying this to send it along channels to the relay actors. That's a severe performance regressionThe text was updated successfully, but these errors were encountered: