Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Do not test nightly rust on every PR #1940

Merged
merged 35 commits into from
Jan 11, 2024
Merged

chore(ci): Do not test nightly rust on every PR #1940

merged 35 commits into from
Jan 11, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Jan 8, 2024

Description

Normal CI jobs for PRs now only run using the stable rust compiler,
this gives fewer surprises to users.

Instead the beta compiler is run in a new workflow which runs once a
week. When the beta workflow fails we get a post in a discord channel.

Notes & open questions

The required checks for branch protection have changed again. We no
longer need the nightly checks in those.

Change checklist

  • Self-review.

Normal CI jobs for PRs now only run using the stable rust compiler,
this gives fewer surprises to users.

Instead the beta compiler is run in a new workflow which runs once a
week.
@flub flub marked this pull request as draft January 8, 2024 15:14
@flub flub marked this pull request as ready for review January 11, 2024 12:15
@flub flub requested a review from Arqu January 11, 2024 12:15
@Arqu Arqu merged commit eab55bf into main Jan 11, 2024
18 checks passed
@Arqu Arqu deleted the flub/ci-beta-rust branch January 11, 2024 13:26
fubuloubu pushed a commit to ApeWorX/iroh that referenced this pull request Feb 21, 2024
## Description

Normal CI jobs for PRs now only run using the stable rust compiler,
this gives fewer surprises to users.

Instead the beta compiler is run in a new workflow which runs once a
week.  When the beta workflow fails we get a post in a discord channel.

## Notes & open questions

The required checks for branch protection have changed again.  We no
longer need the nightly checks in those.

## Change checklist

- [x] Self-review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants