feat(iroh-net): Own the public QUIC API #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This export a lot of quinn types directly from iroh-net::magic_endpoint. These are all the types we need to interact with iroh-net in our own code. The goal is that users should not need to figure out how to add their own (iroh-)quinn dependency to use iroh-net, instead all types should be provided by iroh-net. Not all APIs are re-exported however, to avoid exporting too much. Hopefully what iroh itself needs is a reasonable indication of what is needed, we can always add more.
flub
changed the title
iroh-gossip/src/net.rs
Outdated
| /// [`Connection`]: iroh_net::magic_endpoint::Connection | ||
| pub async fn handle_connection( | ||
| &self, | ||
| conn: iroh_net::magic_endpoint::Connection, |
There was a problem hiding this comment.
we already do a bunch of iroh_net imports in these files. Why not do the same and keep the docs and params simply referring the import? The new state is a tad too verbose for my liking. What do you think?
There was a problem hiding this comment.
I went with a direct replacement as I was not editing the local code: if quinn::SomeThing was used I replaced it without imports as well. It is true the new full name is a lot longer. It will probably also change to iroh_net::endpoint sometime soon as well which is at least a bit shorter.
I will attempt some cleanup.
There was a problem hiding this comment.
290e447 is more aggressive with imports, hope this is better
divagant-martian
approved these changes
May 10, 2024
dignifiedquire
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This export a lot of quinn types directly from
iroh-net::magic_endpoint. These are all the types we need to interact
with iroh-net in our own code. The goal is that users should not need
to figure out how to add their own (iroh-)quinn dependency to use
iroh-net, instead all types should be provided by iroh-net.
Not all APIs are re-exported however, to avoid exporting too much.
Hopefully what iroh itself needs is a reasonable indication of what is
needed, we can always add more.
Breaking Changes
Notes & open questions
Change checklist