[ignore] chore(ci): ci warnings stuff #2556
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is commit
980b53d: refactor(iroh-bytes): Rewrite the blob store to use redb (#2051)
with two commits on top:
git restore .github --source main
and
cargo update -p time
because of some regression in type inference or somethingThis generates some warnings:
Now quickly about the trait Io is never used and others, I kinda ignored them at the point because that's not what I wanted to check but those should ofc make ci fail as well.
About the cfg. This not unification or anything like that, not related to features of dependencies, etc. There is a line in that commit (two lines actually) that put some tests behind said feature with
this is an issue because those tests have not been compiled at all in the last 4-5 months since that line was added. So, I wanted to understand how is that we didn't realize
My question here is why are the test workflows not failing now if I'm using the latest github folder
Breaking Changes
Notes & open questions
Change checklist