Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignore] chore(ci): ci warnings stuff #2556

Closed

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Jul 26, 2024

Description

this is commit 980b53d: refactor(iroh-bytes): Rewrite the blob store to use redb (#2051)
with two commits on top: git restore .github --source main
and cargo update -p time because of some regression in type inference or something

This generates some warnings:

Now quickly about the trait Io is never used and others, I kinda ignored them at the point because that's not what I wanted to check but those should ofc make ci fail as well.

About the cfg. This not unification or anything like that, not related to features of dependencies, etc. There is a line in that commit (two lines actually) that put some tests behind said feature with

warning: unexpected `cfg` condition value: `file-db`
   --> iroh-cli/tests/cli.rs:216:7
    |
216 | #[cfg(feature = "file-db")]

this is an issue because those tests have not been compiled at all in the last 4-5 months since that line was added. So, I wanted to understand how is that we didn't realize

My question here is why are the test workflows not failing now if I'm using the latest github folder

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@divagant-martian divagant-martian force-pushed the check-warnings branch 5 times, most recently from ef1b833 to f908c26 Compare July 26, 2024 22:07
@divagant-martian divagant-martian changed the title chore(ci): ensure we are denying warnings properly [ignore] chore(ci): ci warnings stuff Jul 26, 2024
@divagant-martian divagant-martian force-pushed the check-warnings branch 3 times, most recently from 0b300a0 to 7abb07f Compare July 29, 2024 13:14
@divagant-martian
Copy link
Contributor Author

Updates to the last commit before the issue was fixed and it's reproducible that tests don't fail. However, I can't really figure out what's going on and latest code seems to work even if this already uses latest .github folder. Closing this since I've run out of ideas for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant