test(iroh): Reduce entry amount in sync_gossip_bulk
#2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
Aug 9, 2024
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2608/docs/iroh/ Last updated: 2024-08-09T12:03:46Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test currently runs 55s on our windows CI machines, it runs 40s when I run it on my laptop locally.
If anyone is curious: In release mode, the test runs 0.4s. 🙃
The test basically sync 1000 entries twice. The number is configurable and the default was arbitrarily chosen according to @Frando, so I've reduced it by a factor of 10. With
n_entries = 100the test runs ~4.5s for me, much more reasonable.Breaking Changes
None
Notes & open questions
Change checklist
[ ] Documentation updates following the style guide, if relevant.