feat: expose locally discovered node id and addresses #2612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've had multiple requests for user to get a list of nodes that have been discovered on the local network when using
local-swarm-discovery
. This is my attempt.Breaking Changes
Adds
locally_discovered_nodes
method toDiscovery
traitAdds
locally_discovered_nodes
method to theEndpoint
Adds rpc structs and a
locally_discovered_nodes
method on the client.Notes & open questions
This may be a tragic addition to the
Discovery
trait, but wanted to get feedback.Essentially, this adds a
locally_discovered_nodes
method to theDiscovery
trait, that returnsNone
, unless your discovery mechanism discovers nodes locally.I'm not sure how else we would expose this, without a large
Discovery
refactor.Change checklist