fix(iroh-willow): Remove flume dependency
#2674
Conversation
| match tokio::runtime::Handle::try_current() { | ||
| Ok(runtime) => { | ||
| let (dumb, _) = tokio::sync::mpsc::channel(1); | ||
| let inbox_tx = std::mem::replace(&mut self.inbox_tx, dumb); | ||
| runtime | ||
| .spawn(async move { inbox_tx.send(Input::Shutdown { reply: None }).await }); | ||
| } | ||
| Err(_) => { | ||
| self.inbox_tx | ||
| .blocking_send(Input::Shutdown { reply: None }) | ||
| .ok(); | ||
| } | ||
| } |
There was a problem hiding this comment.
@Frando obviously this is quite a workaround for the fact that blocking_send panics if there's a runtime.
We should either move this into some central utility, or just switch to async_channel instead (like most other places, tbh).
But kind of good to know that an MPSC is technically good enough for us.
There was a problem hiding this comment.
Yeah. I don't have a better solution OTOH. @rklaehn fought this hard as well.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2674/docs/iroh/ Last updated: 2024-08-28T06:45:16Z |
Frando
force-pushed
the
willow-rpc
branch
3 times, most recently
from
81cf06d
to
74f90ad
Compare
|
Ah, sorry, I force-pushed the willow-rpc branch. My current working with the various willow branches was:
Maybe should stop the latter and instead merge willow into the feature branches, now that I'm not the only one working on it :D |
matheus23
changed the title
flume dependency
matheus23
force-pushed
the
matheus23/willow-flume-purge
branch
from
e80a542
to
33df65a
Compare
Don't worry about it! I was just lazy and based the branch on top of I changed the base to |
Description
Purging
flumeas a dependency fromiroh-willow.Breaking Changes
Notes & open questions
Well, there's the whole "make a last send in
impl Drop" thing.Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.