deps(iroh-gossip): Do not depend directly on Quinn #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2678/docs/iroh/ Last updated: 2024-08-29T11:27:09Z |
matheus23
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Yeah - I'm really confused.
I swear this is another change I did during self-review at some point, but got lost somehow.
The reason the dependency here used to exist is because not enough quinn types were exposed in iroh-net, specifically error types.
We added those re-exports in iroh-net, now iroh-gossip doesn't have to depend on quinn itself anymore.
I think this may be a merge thing... because in this PR you didn't have to change the iroh-net & iroh-gossip code (which I had to do the last time).
Anyhow.
iroh-gossip has a direct dependency on Quinn but does not need it. Remove this.
flub
force-pushed
the
flub/gossip-no-quinn
branch
from
e5a6ca6
to
aaceb16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iroh-gossip has a direct dependency on Quinn but does not need it. Remove this.
Breaking Changes
none
Notes & open questions
Please do not merge before #2595 is merged. I'm trying to not modify that PR any further.
Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.[ ] All breaking changes documented.