Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(iroh-cli): udpate doctor command documentation #2710

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

palozano
Copy link
Contributor

@palozano palozano commented Sep 5, 2024

Description

Update documentation to doctor command submodule.

This partially addresses #2660, and belongs to a series of PRs to complete it.

Breaking Changes

Notes & open questions

Imports have been formated to be grouped.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@b5 b5 added the docs Improvements or additions to documentation label Sep 5, 2024
Copy link
Contributor

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, can you use e.g. "Updates the progress bar" instead of "Update the progress bar" in general though? We've only recently adopted a new documentation style guide, so we're not super consistent at this yet, but we should try moving towards using it more.

The summary line should be written in third person singular present indicative form. Basically, this means write ‘Returns’ instead of ‘Return’.

I know it's easy to skip this sentence in the guide (I had to look for it a bit just now, too), but if you could update the PRs to use this style, it'd be great :)

@palozano
Copy link
Contributor Author

palozano commented Sep 6, 2024

Thanks for this, can you use e.g. "Updates the progress bar" instead of "Update the progress bar" in general though? We've only recently adopted a new documentation style guide, so we're not super consistent at this yet, but we should try moving towards using it more.

The summary line should be written in third person singular present indicative form. Basically, this means write ‘Returns’ instead of ‘Return’.

Completely missed this. Thanks!

I know it's easy to skip this sentence in the guide (I had to look for it a bit just now, too), but if you could update the PRs to use this style, it'd be great :)

Yeah, for sure.

@matheus23 matheus23 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into n0-computer:main with commit 93b400a Sep 6, 2024
28 checks passed
@palozano palozano deleted the palozano/cli-docs-doctor branch September 6, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants