Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iroh-willow): refactor peer manager so that proptest passes reliably #2727

Merged
merged 7 commits into from
Sep 24, 2024
Merged

refactor(iroh-willow): refactor peer manager so that proptest passes reliably #2727

merged 7 commits into from
Sep 24, 2024

Conversation

Frando
Copy link
Member

@Frando Frando commented Sep 10, 2024 •
edited
Loading

Description

Fixes #2695

  • Refactor peer manager to really keep track of all connections, the previous logic of a single peer state was flawed for simultaneous accepts while closing previous connections.
  • Better debuggability of reconciler
  • Add proptest from WIP: failing proptest for willow sync #2695 and refactor to run in both directions simultaneously.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2727/docs/iroh/

Last updated: 2024-09-24T13:29:28Z

@Frando Frando mentioned this pull request Sep 16, 2024
Closed
6 tasks
@matheus23 matheus23 self-assigned this Sep 23, 2024
@matheus23
Copy link
Contributor

Will take this over now ✌️

@matheus23 matheus23 marked this pull request as ready for review September 24, 2024 13:29
@matheus23 matheus23 merged commit 63c9557 into willow Sep 24, 2024
7 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheus23 matheus23 matheus23 approved these changes

Assignees

@matheus23 matheus23

Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frando @matheus23