Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #864

Merged
merged 7 commits into from
Oct 24, 2021
Merged

Improve CI #864

merged 7 commits into from
Oct 24, 2021

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Oct 23, 2021

  • Create a tsconfig.build.json file to exclude tests and stuff so build process doesn't do type checking on test files but we still use tsconfig.json to do type checking on test files yarn ts:check and I've added a workflow for that.
  • Extract ESM Test, Lint, Build and Unit Testing into different workflows
  • Use babel typescript instead of ts jest for performance
  • CI workflow is ready to have tests for multiple GraphQL versions. GraphQL v14 was failing, that's why I couldn't enable it. After merging this, I can work on fixing the issues for v14 and v16.
  • Cache node_modules instead of yarn cache folder

@vercel
Copy link

vercel bot commented Oct 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/envelop/6VQGxkm3wDPYb8MBPQMyUmNZmyWY
✅ Preview: https://envelop-git-improve-ci-theguild.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2021

⚠️ No Changeset found

Latest commit: 6004a1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented Oct 23, 2021

The latest changes of this PR are not available as alpha, since there are no linked changesets for this PR.

@theguild-bot
Copy link
Collaborator

theguild-bot commented Oct 23, 2021

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 150100      ✗ 0    
     data_received......................................: 580 MB  12 MB/s
     data_sent..........................................: 33 MB   655 kB/s
     envelop_init.......................................: avg=873ns    min=200ns    med=500ns   max=683.31µs p(90)=1.9µs    p(95)=2.1µs   
     ✓ { mode:envelop-cache-jit }.......................: avg=407ns    min=200ns    med=400ns   max=87.9µs   p(90)=500ns    p(95)=700ns   
     ✓ { mode:envelop-just-cache }......................: avg=558ns    min=300ns    med=500ns   max=305.9µs  p(90)=600ns    p(95)=800ns   
     ✓ { mode:graphql-js }..............................: avg=1.01µs   min=200ns    med=600ns   max=85.6µs   p(90)=1.9µs    p(95)=2µs     
     ✓ { mode:prom-tracing }............................: avg=3.66µs   min=1.3µs    med=2.1µs   max=683.31µs p(90)=7.3µs    p(95)=7.6µs   
     envelop_total......................................: avg=315.51µs min=0s       med=125µs   max=14.23ms  p(90)=496.73µs p(95)=1.48ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=125.05µs min=101µs    med=113.2µs max=10.03ms  p(90)=130.2µs  p(95)=145µs   
     ✓ { mode:envelop-just-cache }......................: avg=368.02µs min=297.8µs  med=315.8µs max=14.23ms  p(90)=347.58µs p(95)=420.65µs
     ✓ { mode:graphql-js }..............................: avg=507.08µs min=403.8µs  med=434µs   max=12.53ms  p(90)=507.99µs p(95)=694.88µs
     ✓ { mode:prom-tracing }............................: avg=1.63ms   min=1.42ms   med=1.49ms  max=11.5ms   p(90)=1.67ms   p(95)=2.67ms  
     event_loop_lag.....................................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-cache-jit }.......................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-just-cache }......................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:graphql-js }..............................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:prom-tracing }............................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     graphql_context....................................: avg=5µs      min=2.1µs    med=3.3µs   max=7.79ms   p(90)=7.3µs    p(95)=8.5µs   
     ✓ { mode:envelop-cache-jit }.......................: avg=3.11µs   min=2.1µs    med=2.8µs   max=2.85ms   p(90)=3.6µs    p(95)=3.9µs   
     ✓ { mode:envelop-just-cache }......................: avg=4.81µs   min=2.5µs    med=3.2µs   max=7.79ms   p(90)=3.9µs    p(95)=4.4µs   
     ✓ { mode:graphql-js }..............................: avg=7.21µs   min=3.2µs    med=5.2µs   max=3.06ms   p(90)=8.8µs    p(95)=11.1µs  
     ✓ { mode:prom-tracing }............................: avg=9.39µs   min=6µs      med=7µs     max=1.87ms   p(90)=9.4µs    p(95)=10.1µs  
     graphql_execute....................................: avg=334.51µs min=68.7µs   med=274.6µs max=14.2ms   p(90)=1.06ms   p(95)=1.4ms   
     ✓ { mode:envelop-cache-jit }.......................: avg=86.09µs  min=68.7µs   med=77.5µs  max=10ms     p(90)=86.7µs   p(95)=98.74µs 
     ✓ { mode:envelop-just-cache }......................: avg=324.88µs min=264.3µs  med=278.9µs max=14.2ms   p(90)=304.3µs  p(95)=359.47µs
     ✓ { mode:graphql-js }..............................: avg=328.76µs min=266.6µs  med=280.3µs max=12.38ms  p(90)=310.6µs  p(95)=345.59µs
     ✓ { mode:prom-tracing }............................: avg=1.53ms   min=1.33ms   med=1.4ms   max=11.29ms  p(90)=1.5ms    p(95)=2.53ms  
     graphql_parse......................................: avg=10.72µs  min=3.1µs    med=4.7µs   max=3.94ms   p(90)=24.9µs   p(95)=40.6µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=5.37µs   min=3.2µs    med=4.5µs   max=2.4ms    p(90)=6.9µs    p(95)=8.2µs   
     ✓ { mode:envelop-just-cache }......................: avg=4.91µs   min=3.1µs    med=3.9µs   max=1.83ms   p(90)=5.1µs    p(95)=10µs    
     ✓ { mode:graphql-js }..............................: avg=13.97µs  min=7µs      med=10.6µs  max=3.94ms   p(90)=19µs     p(95)=23.44µs 
     ✓ { mode:prom-tracing }............................: avg=45.53µs  min=32µs     med=40.9µs  max=1.58ms   p(90)=48.8µs   p(95)=53.3µs  
     graphql_validate...................................: avg=58.08µs  min=24.7µs   med=29.4µs  max=12ms     p(90)=133.55µs p(95)=143.6µs 
     ✓ { mode:envelop-cache-jit }.......................: avg=30.05µs  min=24.7µs   med=27.9µs  max=7.79ms   p(90)=33.09µs  p(95)=34.8µs  
     ✓ { mode:envelop-just-cache }......................: avg=32.84µs  min=25.4µs   med=28.5µs  max=6.02ms   p(90)=33.79µs  p(95)=36.6µs  
     ✓ { mode:graphql-js }..............................: avg=156.1µs  min=120µs    med=133µs   max=12ms     p(90)=163.39µs p(95)=188.9µs 
     ✓ { mode:prom-tracing }............................: avg=41.2µs   min=32µs     med=35.1µs  max=1.86ms   p(90)=41.1µs   p(95)=46.01µs 
     http_req_blocked...................................: avg=4.47µs   min=800ns    med=1.6µs   max=10.24ms  p(90)=2.4µs    p(95)=2.9µs   
     http_req_connecting................................: avg=1.71µs   min=0s       med=0s      max=9.13ms   p(90)=0s       p(95)=0s      
     http_req_duration..................................: avg=6.2ms    min=323.4µs  med=4.56ms  max=82.35ms  p(90)=14.23ms  p(95)=16.45ms 
       { expected_response:true }.......................: avg=6.2ms    min=323.4µs  med=4.56ms  max=82.35ms  p(90)=14.23ms  p(95)=16.45ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=5.43ms   min=568.7µs  med=4.26ms  max=51.96ms  p(90)=9.03ms   p(95)=10.74ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=3.5ms    min=323.4µs  med=2.43ms  max=37.35ms  p(90)=8.36ms   p(95)=11.16ms 
     ✓ { mode:envelop-just-cache }......................: avg=5.93ms   min=560.1µs  med=4.59ms  max=61.55ms  p(90)=9.64ms   p(95)=12.73ms 
     ✓ { mode:graphql-js }..............................: avg=7.83ms   min=853.81µs med=6.17ms  max=62.78ms  p(90)=12.67ms  p(95)=16.2ms  
     ✓ { mode:prom-tracing }............................: avg=18.36ms  min=2.34ms   med=16.3ms  max=82.35ms  p(90)=31.06ms  p(95)=32.89ms 
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 75050
     http_req_receiving.................................: avg=57.28µs  min=13.8µs   med=25µs    max=26.7ms   p(90)=37.29µs  p(95)=43.1µs  
     http_req_sending...................................: avg=64.31µs  min=4.89µs   med=9.7µs   max=28.51ms  p(90)=19.9µs   p(95)=26.8µs  
     http_req_tls_handshaking...........................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...................................: avg=6.07ms   min=296.1µs  med=4.48ms  max=82.31ms  p(90)=13.77ms  p(95)=16.36ms 
     http_reqs..........................................: 75050   1500.645683/s
     iteration_duration.................................: avg=6.65ms   min=559.5µs  med=4.92ms  max=83.39ms  p(90)=14.98ms  p(95)=16.9ms  
     iterations.........................................: 75050   1500.645683/s
     vus................................................: 8       min=8         max=10 
     vus_max............................................: 40      min=40        max=40 

- name: Use Node
uses: actions/setup-node@master
with:
node-version: '16.8.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 16.8.0 in specific when 16.12.0 is already out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if this bug has been fixed;
nodejs/node#40030

@ardatan
Copy link
Collaborator Author

ardatan commented Oct 24, 2021

@dotansimha Let's merge asap so we can extend the matrix with v14 and v16

@dotansimha dotansimha merged commit eb38f44 into main Oct 24, 2021
@ardatan ardatan deleted the improve-CI branch October 24, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants