-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #864
Improve CI #864
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/envelop/6VQGxkm3wDPYb8MBPQMyUmNZmyWY |
|
The latest changes of this PR are not available as alpha, since there are no linked |
✅ Benchmark Results
|
.github/workflows/tests.yml
Outdated
- name: Use Node | ||
uses: actions/setup-node@master | ||
with: | ||
node-version: '16.8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 16.8.0 in specific when 16.12.0 is already out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if this bug has been fixed;
nodejs/node#40030
@dotansimha Let's merge asap so we can extend the matrix with v14 and v16 |
tsconfig.json
to do type checking on test filesyarn ts:check
and I've added a workflow for that.