Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger NoLiveMixedWithDeferStreamRule only if query has @live directive #1023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarne
Copy link

@aarne aarne commented Dec 29, 2023

Some queries with fragments marked with @defer would trigger this error without actually having @live directive in the query

example query:

{
  containers {
    id
    ...TriggerError
  }
}

fragment TriggerError on Container {
  id
  ... on Container @defer {
    stats
  }
}

…irective

Some queries with fragments marked with @defer would trigger this error without actually having @LiVe directive in the query
Copy link

changeset-bot bot commented Dec 29, 2023

⚠️ No Changeset found

Latest commit: 3c66b79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n1ru4l
Copy link
Owner

n1ru4l commented Dec 30, 2023

@aarne can you please add a test case for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants